Issue with rule using MAX function

thom

I have 2 BOs; Template and TemplateTasks. TemplateTasks appear as a Table of Items in a section of the Template Form. The table is sorted by an attribute called SortOrder.

I have a rule on SortOrder to default an order when creating a new TemplateTask - this rule is set to work on initialization:

IF TemplateTasks IS NEW THEN TemplateTasks.SortOrder=MAX

TemplateTasks.SortOrder WHERE (TemplateTasks.Template=ThisTemplateTasks.Template)+1

I have a process to create a new TemplateTask
ENTER NEW TemplateTasks WITH TemplateTasks.Template=Template

Now, when I Add New, using the rule above, the Form appears, with the SortOrder defaulted correctly, but when I enter data and save the form the SortOrder is saved with a value that is +2 or the last SortOrder value and +1 of the value as it is displayed when entering a new task.

For instance, if the TemplateTask currently has two rows in it (sortorder numbers 1 and 2), when I click add, the New TemplateTask defaults the SortOrder to 3 (as expected), but when I save the form, the row is saved with a 4 rather than a 3.

Any ideas?

tford

Try using an AND that makes it ignore the current instance like this Regular User rule that is in every new BSV:

If EXISTS SystemUser WHERE (SystemUser.LoginName=ThisRegularUser.LoginName AND SystemUser.ID<>ThisRegularUser.ID) Then REPORT ERROR 'User with this login name already exists. Please choose a different name'

thom

Hi Tom,

I have no clue as to how this rule would apply to this issue - did you post this reply on the wrong thread?

tford

Sorry Thom. Try this:

IF TemplateTasks IS NEW THEN TemplateTasks.SortOrder=MAX
TemplateTasks.SortOrder WHERE (TemplateTasks.Template=ThisTemplateTasks.Template AND TemplateTasks.ID<>ThisTemplateTasks.ID)+1

thom

sorry, I now understand your reference above to the use of AND. This does make sense to me, but it does not completely resolve my issue.

Previously, the logic defaulted the correct SortOrder number on new(or edit), but saved the wrong number.

After applying the "AND" logic it now always defaults the number 1 to the sort order, but saves the correct number.

thanks
t

tford

Does the sort order need to show at all, or is it just an attribute that is just for system use?

thom

It does need to show because it allows them to "modify" where the tasks appear in the list.

The broader scope is that TemplateTasks is a core of a scheduling function that will allow for iterative or sequential scheduling of tasks. I am looking to "default" the order, but anticipate that it will be modify upon entry (for some tasks) on a frequent basis.

thanks
t

tford

Hmm. It seems like you really just want a default value & do not want the rule logic to fire when the user clicks save.

Would this work to add new TemplateTasks:
ENTER NEW TemplateTasks WITH TemplateTasks.SortOrder=MAX
TemplateTasks.SortOrder WHERE (TemplateTasks.Template=ThisTemplateTasks.Template)+1

tford

Or, if you don't want the new instance to be in a modal form, you could use:

CREATE TemplateTasks WITH TemplateTasks.SortOrder=MAX
TemplateTasks.SortOrder WHERE (TemplateTasks.Template=ThisTemplateTasks.Template)+1

VIEW Template USING Main

thom

Yes, I want the rule to fire on initialization (which I checked), but I do not want it to fire on save.

I previously tried adding the SortOrder on the Add New process instead of a BO rule - although my rule looked more like the following

ENTER NEW TemplateTasks WITH TemplateTasks.SortOrder=MAX TemplateTasks.SortOrder WHERE (TemplateTasks.Template=ThisTemplateTasks.Template)+1, TemplateTasks.Template=Template USING Main

when I use this logic, I never get SortOrder to increment, either on form load or on save. It always gives me a 1.

This whole thing makes me wonder if there is not a bug with this -
Using my initial rule (without your AND logic) I get the right default value, but on the save it increments +1 on top of the defaulted value. It is almost as if the rule is firing on both the initialization as well as on save - shouldn't this be one or the other?

tford

Try this:

ENTER NEW TemplateTasks WITH TemplateTasks.SortOrder=MAX TemplateTasks.SortOrder WHERE (TemplateTasks IN Template.TemplateTasks)+1, TemplateTasks.Template=Template USING Main

Make sure you don't also have a rule firing. The default setting of TemplateTasks.SortOrder via ENTER NEW should be the only place it's value is set.

thom

Tom,

That did it! Thanks for you time and effort.

There are a couple of lessons here that I want to document

Set logic for default attributes (in this specific case) on the Process rather then the BO Rule.
Use the "IN" condition rather than the "=" when you have multiples